2 reports based on one query

On Wed, 3 Sep 2008 06:24:01 -0700, randria wrote:

> Hello,
>
> I have a form that supplies parameters to a query. I have 2 different
> reports ( OSrpt and ONrpt ) depending on this query. I want to preview OSrpt
> if the categorieID of the supplier selected by the user is equal to 1 and if
> not to preview ONrpt instead.
> this is the code I used but it selects only "ONrpt".
>
> Private Sub Command6_Click()
> On Error GoTo Err_Command6_Click
> Dim stDocName As String
> Dim CategorieID As long
> if CategorieID=1 Then
> stDocName = "OSrpt"
> DoCmd.OpenReport stDocName, acPreview
> else
> stDocName= "ONrpt"
> DoCmd.OpenReport stDocName, acPreview
> End if
>
> Exit_Command6_Click:
> Exit Sub
>
> Err_Command6_Click:
> MsgBox Err.Description
> Resume Exit_Command6_Click
>
> End Sub
>
> the problem is that even if the 1st condition is true, it displays the
> records on the report "ONrpt".
> Many thanks.
> randria

Regarding ...
Dim CategorieID As long
if CategorieID=1 Then
When your code runs, CategorieID is ALWAYS 0.
No where in the above to you give it a value.

If the only difference between the 2 reports is the criteria, then you
should have just one report, and filter the data using the Where
clause argument of the OpenReport method. See VBA help on the
OpenReport method and also
Where clause + Restrict data to a subset of records.

If there is more than just the criteria difference between the 2
reports, then you must give CategoryID a value, i.e.
Dim CategoryID as Long
CategoryID = [SomeControlValue]
If CategoryID = 1 Then
.... etc...

Though if you are doing that, then it's just simpler to use:

Dim stDocName as String
If [SomeControlValue] = 1 then
stDocName = "OSrpt"
Else
stDocName = "ONrpt"
End If
DoCmd.OpenReport stDocName, acViewPreview


--
Fred
Please respond only to this newsgroup.
I do not reply to personal e-mail

randria wrote:
>I have a form that supplies parameters to a query. I have 2 different
>reports ( OSrpt and ONrpt ) depending on this query. I want to preview OSrpt
>if the categorieID of the supplier selected by the user is equal to 1 and if
>not to preview ONrpt instead.
>this is the code I used but it selects only "ONrpt".
>
>Private Sub Command6_Click()
>On Error GoTo Err_Command6_Click
>Dim stDocName As String
>Dim CategorieID As long
> if CategorieID=1 Then
> stDocName = "OSrpt"
> DoCmd.OpenReport stDocName, acPreview
>else
> stDocName= "ONrpt"
> DoCmd.OpenReport stDocName, acPreview
>End if
>
>Exit_Command6_Click:
>Exit Sub
>
>Err_Command6_Click:
>MsgBox Err.Description
>Resume Exit_Command6_Click
>
>End Sub


If CategorieID is a control on the form, then remove the
line:
Dim CategorieID As Long

--
Marsh
MVP [MS Access]

Hi Jeff, Fred and Marshall

Many thanks for your repiies they all gave me some useful options, I have to
have 2 reports and Fred's code solved the problem. Below is the code:

Private Sub Command6_Click()
On Error GoTo Err_Command6_Click
Dim stDocName As String
Dim CategorieID As long
CategorieID=[cbo0] ' this is what was missing the combo on the form.
if CategorieID=1 Then
stDocName = "OSrpt"
DoCmd.OpenReport stDocName, acPreview
else
stDocName= "ONrpt"
DoCmd.OpenReport stDocName, acPreview
End if

Exit_Command6_Click:
Exit Sub

Err_Command6_Click:
MsgBox Err.Description
Resume Exit_Command6_Click

End Sub
Many thanks.

"fredg" wrote:

> On Wed, 3 Sep 2008 06:24:01 -0700, randria wrote:
>
> > Hello,
> >
> > I have a form that supplies parameters to a query. I have 2 different
> > reports ( OSrpt and ONrpt ) depending on this query. I want to preview OSrpt
> > if the categorieID of the supplier selected by the user is equal to 1 and if
> > not to preview ONrpt instead.
> > this is the code I used but it selects only "ONrpt".
> >
> > Private Sub Command6_Click()
> > On Error GoTo Err_Command6_Click
> > Dim stDocName As String
> > Dim CategorieID As long
> > if CategorieID=1 Then
> > stDocName = "OSrpt"
> > DoCmd.OpenReport stDocName, acPreview
> > else
> > stDocName= "ONrpt"
> > DoCmd.OpenReport stDocName, acPreview
> > End if
> >
> > Exit_Command6_Click:
> > Exit Sub
> >
> > Err_Command6_Click:
> > MsgBox Err.Description
> > Resume Exit_Command6_Click
> >
> > End Sub
> >
> > the problem is that even if the 1st condition is true, it displays the
> > records on the report "ONrpt".
> > Many thanks.
> > randria
>
> Regarding ...
> Dim CategorieID As long
> if CategorieID=1 Then
> When your code runs, CategorieID is ALWAYS 0.
> No where in the above to you give it a value.
>
> If the only difference between the 2 reports is the criteria, then you
> should have just one report, and filter the data using the Where
> clause argument of the OpenReport method. See VBA help on the
> OpenReport method and also
> Where clause + Restrict data to a subset of records.
>
> If there is more than just the criteria difference between the 2
> reports, then you must give CategoryID a value, i.e.
> Dim CategoryID as Long
> CategoryID = [SomeControlValue]
> If CategoryID = 1 Then
> .... etc...
>
> Though if you are doing that, then it's just simpler to use:
>
> Dim stDocName as String
> If [SomeControlValue] = 1 then
> stDocName = "OSrpt"
> Else
> stDocName = "ONrpt"
> End If
> DoCmd.OpenReport stDocName, acViewPreview
>
>
> --
> Fred
> Please respond only to this newsgroup.
> I do not reply to personal e-mail
>