Explain Complie error

Hi,

I introduced a piece of code into my code. (see
http://www.dreamincode.net/forums/showtopic34776.htm)

Part of the code generated an error:

Public Sub ResizeForm(frm As Form)
'Set the forms height
frm.height = Screen.height / 2
'Set the forms width
frm.width = Screen.width / 2
'Resize all of the controls
'based on the forms new size
ResizeControls frm
End Sub

I introduced this code so I got a form that would automatically resize
depending on the screen dimensions of the user.

When I compile the code, I get a 'Compile error' on the following line:
'Public Sub ResizeForm(frm As Form'
Notice it did not include the last bracket.

How should I look at this error? What is wrong with this piece of code. Is
frm unknown, or is it Form. Or is a piece of this Sub used without it being
defined. I know frm is not defined, but is frm something that should have
been "known" by VB?

This must be very basic. But I'm not that versed in Visual Basic.

TIA,
Abel

Note: FWIW, I'm using Word 2002/XP. My VB version is 6.3

Hi Abel,

The problem here is that you've grabbed some VB6 code and tried to plug it
directly into VBA. That often works with code that isn't related to VB forms
and VBA userforms. But VB forms are very different from VBA userforms, so
that kind of code cannot be directly ported.

The first thing you tripped over is that Form is not a valid object type in
VBA; instead you need to use the specific UserForm1 or whatever you may have
renamed that to. (In this case, you can't even use the generic 'UserForm'
type.)

Once you get that fixed, you would find that there is no Screen object in
VBA; instead, the System object has the properties you need, named
HorizontalResolution and VerticalResolution. Further, those two properties
are measured in pixels, while the Height and Width properties of the
UserForm1 object are measured in points. Fortunately, there's a built-in
function to convert pixels to points. You may need to make some similar
adjustments in the ResizeControls procedure.

Finally, in VBA userform-land, the proper place to put code of this kind is
not in the macro code that calls the userform, but in the procedure
UserForm_Initialize within the userform itself. That procedure runs
automatically between the call to the userform's .Show method and the time
the userform actually appears on the screen. Since the procedure is in the
userform, the built-in object Me refers to the userform, so you don't have
to pass the userform as a parameter. The code would be

Private Sub UserForm_Initialize()
Me.Height = PixelsToPoints(System.VerticalResolution / 2)
Me.Width = PixelsToPoints(System.HorizontalResolution / 2)
ResizeControls
End Sub

The ResizeControls procedure can also be made part of the
UserForm_Initialize procedure, and then instead of the line

For Each curr_obj In frm

you would use

For Each curr_obj In Me.Controls

Here's the whole enchilada:

Private Sub UserForm_Initialize()
Dim curr_obj As Control
Dim iHeight As Long, iWidth As Long
Dim x_size As Single
Dim y_size As Single

' save initial values
iHeight = Me.Height
iWidth = Me.Width

Me.Height = PixelsToPoints(System.VerticalResolution / 2)
Me.Width = PixelsToPoints(System.HorizontalResolution / 2)

' calculate resize factors
x_size = CSng(Me.Width) / CSng(iWidth)
y_size = CSng(Me.Height) / CSng(iHeight)

For Each curr_obj In Me.Controls
With curr_obj
.Left = .Left * x_size
.Width = .Width * x_size
.Top = .Top * y_size
.Height = .Height * y_size
End With
Next
End Sub

--
Regards,
Jay Freedman
Microsoft Word MVP FAQ: http://word.mvps.org
Email cannot be acknowledged; please post all follow-ups to the newsgroup so
all may benefit.


Abel MacAdam wrote:
> Hi,
>
> I introduced a piece of code into my code. (see
> http://www.dreamincode.net/forums/showtopic34776.htm)
>
> Part of the code generated an error:
>
> Public Sub ResizeForm(frm As Form)
> 'Set the forms height
> frm.height = Screen.height / 2
> 'Set the forms width
> frm.width = Screen.width / 2
> 'Resize all of the controls
> 'based on the forms new size
> ResizeControls frm
> End Sub
>
> I introduced this code so I got a form that would automatically resize
> depending on the screen dimensions of the user.
>
> When I compile the code, I get a 'Compile error' on the following
> line: 'Public Sub ResizeForm(frm As Form'
> Notice it did not include the last bracket.
>
> How should I look at this error? What is wrong with this piece of
> code. Is frm unknown, or is it Form. Or is a piece of this Sub used
> without it being defined. I know frm is not defined, but is frm
> something that should have been "known" by VB?
>
> This must be very basic. But I'm not that versed in Visual Basic.
>
> TIA,
> Abel
>
> Note: FWIW, I'm using Word 2002/XP. My VB version is 6.3